backend/rs: delay client cleanup #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delay client cleanup until the state lock is dropped to prevent potential deadlocks in drop impls of the client state.
cmeissl
force-pushed
the
fix/client_cleanup_deadlock
branch
from
3cef0cf to
b07d3f3
Compare
cmeissl
force-pushed
the
fix/client_cleanup_deadlock
branch
from
2ff8a99 to
50bb662
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 72.54% 74.08% +1.54%
==========================================
Files 41 46 +5
Lines 6516 7757 +1241
==========================================
+ Hits 4727 5747 +1020
- Misses 1789 2010 +221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Drakulix
approved these changes
Dec 16, 2024
ids1024
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delay client cleanup until the state lock is dropped to prevent potential deadlocks in drop impls of the client state.